On 05.04.2024 11:14, Nicola Vetrini wrote:
> --- a/xen/arch/x86/hvm/hypercall.c
> +++ b/xen/arch/x86/hvm/hypercall.c
> @@ -119,12 +119,12 @@ int hvm_hypercall(struct cpu_user_regs *regs)
>              (mode == 8 ? regs->rdi : regs->ebx) == 
> HVMOP_guest_request_vm_event )
>              break;
>  
> -        if ( unlikely(hvm_get_cpl(curr)) )
> -        {
> +        if ( !unlikely(hvm_get_cpl(curr)) )

likely() / unlikely() want to be the outermost part of a conditional
like this (things are different with && or ||), i.e.

        if ( likely(!hvm_get_cpl(curr)) )

Then:
Acked-by: Jan Beulich <jbeul...@suse.com>

Jan

Reply via email to