On 03.04.2024 12:19, Oleksii Kurochko wrote: > --- a/xen/include/xen/linux-compat.h > +++ b/xen/include/xen/linux-compat.h > @@ -19,4 +19,6 @@ typedef int64_t __s64; > > typedef paddr_t phys_addr_t; > > +#define __ffs(x) (ffsl(x) - 1)
To be truly Linux-compatible, the result type would better be unsigned long here. Seeing that you build upon Andrew's work, the easiest might be #define __ffs(x) (ffsl(x) - 1UL) Then: Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan