On 27.03.2024 19:13, le...@solinno.co.uk wrote: > From: Leigh Brown <le...@solinno.co.uk> > > Rework xenwatchdogd signal handling to do the minimum in the signal > handler. This is a very minor enhancement. > --- > tools/misc/xenwatchdogd.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-)
Throughout the series Signed-off-by: are missing from both you and Leigh. The latter you may of course add only in case of this either having been provided earlier (and dropped for an unknown reason), or with respective agreement. > --- a/tools/misc/xenwatchdogd.c > +++ b/tools/misc/xenwatchdogd.c > @@ -9,9 +9,11 @@ > #include <unistd.h> > #include <signal.h> > #include <stdio.h> > +#include <stdbool.h> > > xc_interface *h; > -int id = 0; > +bool safeexit = false; > +bool done = false; Seeing the subsequent patch adding static, please don't introduce new non-static items. Jan
