On 14.03.2024 23:15, Shawn Anastasio wrote: > Introduce a generic acpi.h header that provides the required definitions > to allow files including xen/acpi.h to be compiled. The definitions were > largely derived from the !CONFIG_ACPI parts of ARM's acpi.h.
As said a couple of times in discussion with Oleksii on his work towards populating asm-generic/, I view a use like this as an abuse of this asm-generic machinery. Instead imo said !CONFIG_ACPI parts from Arm's header want moving to xen/acpi.h, eliminating the need for asm/acpi.h for architectures / configurations not supporting ACPI. Much like was done with e.g. xen/numa.h. Jan > --- a/xen/arch/ppc/include/asm/Makefile > +++ b/xen/arch/ppc/include/asm/Makefile > @@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only > +generic-y += acpi.h > generic-y += altp2m.h > generic-y += device.h > generic-y += div64.h > --- /dev/null > +++ b/xen/include/asm-generic/acpi.h > @@ -0,0 +1,20 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __ASM_GENERIC_ACPI_H > +#define __ASM_GENERIC_ACPI_H > + > +#include <asm/page.h> > +#include <xen/types.h> > + > +#ifdef CONFIG_ACPI > +#error "asm-generic acpi.h can't be used with CONFIG_ACPI set" > +#endif > + > +#define COMPILER_DEPENDENT_INT64 int64_t > +#define COMPILER_DEPENDENT_UINT64 uint64_t > +#define ACPI_MAP_MEM_ATTR PAGE_HYPERVISOR > + > +#define acpi_disabled (true) > +#define disable_acpi() > +#define enable_acpi() > + > +#endif /* __ASM_GENERIC_ACPI_H */
