On 22.03.2024 17:01, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be safe with respect to expansions that > can possibly alter the semantics of the passed-in macro parameter. > > No functional change. > > Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com>
Seeing this is again touching an imported header, we finally need to settle on where to draw the line. The way this is going is that you're proposing many small changes which individually all look "small enough". Yet when doing so for long enough, the entire header may end up different from its original. Jan > --- a/xen/include/efi/efiapi.h > +++ b/xen/include/efi/efiapi.h > @@ -63,7 +63,8 @@ EFI_STATUS > OUT UINT32 *DescriptorVersion > ); > > -#define NextMemoryDescriptor(Ptr,Size) ((EFI_MEMORY_DESCRIPTOR *) (((UINT8 > *) Ptr) + Size)) > +#define NextMemoryDescriptor(Ptr,Size) ((EFI_MEMORY_DESCRIPTOR *) \ > + ((UINT8 *)(Ptr) + (Size))) > > > typedef
