On 18.03.2024 17:35, Andrew Cooper wrote: > This logically drops the cycles parameter, as it's now encoded directly in the > event code.
That encoding is an internal detail of the new API; for the purposes of the callers the pattern looks to be that ... > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c > @@ -67,7 +67,7 @@ static void hvmtrace_io_assist(const ioreq_t *p) > size *= 2; > } > > - trace_var(event, 0/*!cycles*/, size, buffer); > + trace(event, size, buffer); ... the respective parameter being 0 translates to trace(), while ... > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -135,7 +135,7 @@ static void _trace_irq_mask(uint32_t event, int irq, int > vector, > > memcpy(d.mask, mask, > min(sizeof(d.mask), BITS_TO_LONGS(nr_cpu_ids) * sizeof(long))); > - trace_var(event, 1, sizeof(d), &d); > + trace_time(event, sizeof(d), &d); ... the parameter being 1 translates to trace_time(). Imo the description would better express it that way. Irrespective, assuming that pattern is what is meant to hold, Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan
