On 18.03.2024 12:53, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be safe with respect to expansions that > can possibly alter the semantics of the passed-in macro parameter. > > No functional change. > > Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com> > --- > This file is matched by exclude-list.json, but the fix is rather trivial > and actually benefits code that is in scope for compliance.
Hmm, yes, the change is simple enough to not be a big hindrance even if we were to pull in incremental updates from gnu-efi, so Acked-by: Jan Beulich <jbeul...@suse.com> Albeit preferably with ... > --- a/xen/include/efi/efierr.h > +++ b/xen/include/efi/efierr.h > @@ -22,7 +22,7 @@ Revision History > > > #define EFIWARN(a) (a) > -#define EFI_ERROR(a) (((INTN) a) < 0) > +#define EFI_ERROR(a) (((INTN)(a)) < 0) ... excess parentheses dropped in exchange: #define EFI_ERROR(a) ((INTN)(a) < 0) I may take the liberty of doing so while committing. Jan
