On 13.03.2024 18:27, Andrew Cooper wrote: > --- a/xen/common/bitops.c > +++ b/xen/common/bitops.c > @@ -47,6 +47,18 @@ static void test_ffs(void) > CHECK(ffsl, 1UL << (BITS_PER_LONG - 1), BITS_PER_LONG); > if ( BITS_PER_LONG > 32 ) > CHECK(ffsl, 1UL << 32, 33); > + > + /* > + * unsigned int ffs64(uint64_t) > + * > + * 32-bit builds of Xen have to split this into two adjacent operations, > + * so test all interesting bit positions. > + */ > + CHECK(ffs64, 0, 0); > + CHECK(ffs64, 1, 1); > + CHECK(ffs64, (uint64_t)0x0000000080000000, 32); > + CHECK(ffs64, (uint64_t)0x0000000100000000, 33); > + CHECK(ffs64, (uint64_t)0x8000000000000000, 64);
I'm pretty sure Misra will want ULL suffixes on the last two and at least an UL one on the middle of the lines. The casts aren't going to help (and could then be dropped). Jan
