On 09/03/2024 06:44, Henry Wang wrote:
Hi Julien,
Hi Julien/Henry,

On 3/9/2024 6:30 AM, Julien Grall wrote:
(+ Ayan + Henry)

(- my old email address + the new one)

Hi Carlo,

On 29/01/2024 17:18, Carlo Nonato wrote:
Cache coloring must physically relocate Xen in order to color the hypervisor
and consider_modules() is a key function that is needed to find a new
available physical address.

672d67f339c0 ("xen/arm: Split MMU-specific setup_mm() and related code out") moved consider_modules() under arm32. Move it back to setup.c and make it
non-static so that it can be used outside.

Signed-off-by: Carlo Nonato <carlo.non...@minervasys.tech>
---
v6:
- new patch
---
  xen/arch/arm/arm32/mmu/mm.c      | 93 +-------------------------------
  xen/arch/arm/include/asm/setup.h |  3 ++
  xen/arch/arm/setup.c             | 92 +++++++++++++++++++++++++++++++

Ayan, Henry, will the function consider_modules() be used for the MPU code?

I checked all the MPU branches (the recent arm64 implementation and an arm32 branch to my best knowledge), no I don't think the function will be used for the MPU code. However I am not sure if Ayan has a newer arm32 MPU branch on top of the latest staging or so using the function, Ayan would you like to add some comments?

Yes, Henry is correct.

consider_modules() is mmu specific only.

- Ayan


If not, then I think the function should live in arm/mmu/setup.c.

+1, arm/mmu/setup.c is a good place.

Kind regards,
Henry


Cheers,



Reply via email to