On 3/8/24 00:22, Andrew Cooper wrote:
On 07/03/2024 9:40 pm, Vaishali Thakkar wrote:
The suffix is redundant for np/sev/sev-es bits. Drop it
to avoid adding extra code volume.
Suggested-by: Andrew Cooper <andrew.coop...@citrix.com>
Signed-off-by: Vaishali Thakkar <vaishali.thak...@vates.tech>i
Typo on the end of your email address?
Oops, thanks for catching it.
diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c
index e4e01add8c..7e285cf85a 100644
--- a/xen/arch/x86/hvm/svm/nestedsvm.c
+++ b/xen/arch/x86/hvm/svm/nestedsvm.c
@@ -706,7 +706,7 @@ nsvm_vcpu_vmentry(struct vcpu *v, struct cpu_user_regs
*regs,
}
/* nested paging for the guest */
- svm->ns_hap_enabled = !!ns_vmcb->_np_enable;
+ svm->ns_hap_enabled = !!ns_vmcb->_np;
Because the type of is bool, the !! can be dropped too while changing
this line.
Thanks for the review. As I'm sending the revised patchset anyway,
will fix both things in this patch too.
It seems that this was missing cleanup from f57ae00635 "SVM: split
_np_enable VMCB field".
Anyway, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> and I'm
happy to fix on commit.
