On 2024-03-07 03:26, Jan Beulich wrote:
On 07.03.2024 03:09, Stefano Stabellini wrote:
On Wed, 6 Mar 2024, Jason Andryuk wrote:
Expand bzimage_parse() to return kernel_alignment from the setup_header.
This will be needed if loading a PVH kernel at a physical offset to
compensate for a reserved E820 region.
Signed-off-by: Jason Andryuk <jason.andr...@amd.com>
Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
Acked-by: Jan Beulich <jbeul...@suse.com>
with two remarks:
--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -548,12 +548,14 @@ static int __init pvh_load_kernel(struct domain *d, const
module_t *image,
struct elf_binary elf;
struct elf_dom_parms parms;
paddr_t last_addr;
+ unsigned int align = 0;
Strictly speaking this isn't needed here, yet, and would suffice when added
in the next patch. But I'm okay with keeping it.
--- a/xen/arch/x86/include/asm/bzimage.h
+++ b/xen/arch/x86/include/asm/bzimage.h
@@ -4,8 +4,7 @@
#include <xen/init.h>
unsigned long bzimage_headroom(void *image_start, unsigned long image_length);
-
int bzimage_parse(void *image_base, void **image_start,
- unsigned long *image_len);
+ unsigned long *image_len, unsigned int *align);
Any particular reason for dropping the blank line? I'd prefer if it was kept,
and I may take the liberty to respectively adjust the patch while committing.
No, no particular reason. The blank line can be retained.
Thanks,
Jason
