On 06/03/2024 7:34 am, Jan Beulich wrote: > In light of recent observations with how macros are handled by gas, > let's play by what we informally set for ourselves as a guideline: Use > commas to separate parameters/arguments. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com> However, there are some other examples wanting the same treatment. alternative-asm.h:14:.macro altinstruction_entry orig repl feature orig_len repl_len pad_len asm-defns.h:32:.macro INDIRECT_BRANCH insn:req arg:req asm_defns.h:284:.macro RESTORE_ALL adj=0 compat=0 spec_ctrl_asm.h:107:.macro DO_OVERWRITE_RSB tmp=rax xu Preferably, fix all of these in one go. As for observations about the other architectures, PPC uses commas everywhere. RISC-V has no .macro's. ARM looks to be a 50/50 mix.
