On 04.03.2024 17:10, Andrew Cooper wrote: > It is daft to require all architectures to provide empty implementations of > this functionality. > > Provide evaluate_nospec() and block_speculation() unconditionally in > xen/nospec.h with architectures able to opt in by providing suitable arch > variants. > > Rename x86's implementation to the arch_*() variants. > > No functional change. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Upon further thinking and with Julien's recent reply in mind: Acked-by: Jan Beulich <jbeul...@suse.com> Still I'd prefer if the arch_* were left out. They look to me to go this half step too far (despite now having looked at patch 2 as well; I'll reply there separately). And it is this which was why I decided that going the other half step (moving these handful lines of code) wasn't really worth it, when considering whether to make such a patch myself. Jan
