>>> On 11.06.18 at 12:31, <paul.durr...@citrix.com> wrote: >> From: Roger Pau Monne >> Sent: 11 June 2018 11:26 >> On Fri, Jun 08, 2018 at 04:30:30PM +0100, Paul Durrant wrote: >> > --- a/xen/drivers/passthrough/iommu.c >> > +++ b/xen/drivers/passthrough/iommu.c >> > @@ -52,7 +52,7 @@ custom_param("iommu", parse_iommu_param); >> > bool_t __initdata iommu_enable = 1; >> > bool_t __read_mostly iommu_enabled; >> > bool_t __read_mostly force_iommu; >> > -bool_t __hwdom_initdata iommu_dom0_strict; >> > +bool_t __read_mostly iommu_dom0_strict; >> >> I'm not sure why you need to change the attributes of >> iommu_dom0_strict, AFAICT it's still only used in hwdom_init (or init) >> functions? >> > > That's true at this point. I plan to change it as part of PV-IOMMU. TBH > though I prefer the consistency but I can drop the change if there are any > major objections.
Yes, please change it only at the point it needs changing. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel