On 22.02.2024 10:05, Roger Pau Monne wrote: > The usage of a cmpxchg loop in get_next_handle() is unnecessary, as the same > can be achieved with an atomic increment, which is both simpler to read, and > avoid any need for a loop. > > The cmpxchg usage is likely a remnant of 32bit support, which didn't have an > instruction to do an atomic 64bit add, and instead a cmpxchg had to be used. > > Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> > Signed-of-by: Roger Pau Monné <roger....@citrix.com>
Hmm, same typo again, so my commit script again got the author wrong. I'm sorry again. I would consider adding an explicit confirmation step when there's no (well-formed) S-o-b, but I use this script elsewhere as well, and in e.g. binutils and gcc S-o-b are pretty uncommon. (And to avoid the question: I'm specifically avoiding From: itself in the common case, as for you and other people with non-ASCII characters in their names those typically don't properly show up there.) Jan
