On 2024-02-14 12:49, Jan Beulich wrote:
On 14.02.2024 12:26, Nicola Vetrini wrote:
--- a/automation/eclair_analysis/ECLAIR/deviations.ecl
+++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
@@ -387,6 +387,16 @@ in assignments."
{safe, "left_right(^[(,\\[]$,^[),\\]]$)"}
-doc_end
+-doc_begin="The token pasting in variadic macros cannot be replaced."
+-config=MC3R1.R20.12,macros+={deliberate, "variadic()"}
+-doc_end
+
+-doc_begin="Uses of # and ## operators within the following macros
are
+deliberate."
I don't think this is a good explanation. The use of those operators is
deliberate elsewhere as well.
Implicitly this was intended to be delimited to its applicability scope
- violations of Rule 20.12. I detailed the reasons that were brought up
to keep using these macros as is in the deviations.rst file. I'm open to
further refinements, though.
+-config=MC3R1.R20.12,macros+={deliberate,
"name(ASSERT||BUILD_BUG_ON||BUILD_BUG_ON_ZERO||GENERATE_CASE)"}
I said in another context already that it is necessary to separate
global scope macros from local helper ones. Any CU can introduce
another
GENERATE_CASE(), and would be deviated here right away. In fact I
question applicability of the deviation to arm/arm64/vsysreg.c; I only
see it as applicable to arm/vcpreg.c.
Why wouldn't this be applicable for vsysreg.c? I can certainly fine-tune
the deviation, if needed
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
