On 07/02/2024 1:38 pm, Jan Beulich wrote: > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -599,7 +599,7 @@ domain_crash_page_fault_0x8: > ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP > movq %rsi,%rdi > call show_page_walk > -ENTRY(dom_crash_sync_extable) > +LABEL(dom_crash_sync_extable, 0) > ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP > # Get out of the guest-save area of the stack. > GET_STACK_END(ax) >
This again is a function, and one even used across-TUs. Furthermore, it's a (domain) fatal error path. It has the least excuse of all to not conform to a regular function-like layout. Everything else looks fine. If you want to split this out into a separate patch to address its function-ness, then consider the remainder Acked-by: Andrew Cooper <andrew.coop...@citrix.com>
