On 24.01.2024 16:04, Oleksii wrote: > On Wed, 2024-01-24 at 12:24 +0100, Jan Beulich wrote: >> On 24.01.2024 10:34, Oleksii wrote: >>> On Tue, 2024-01-23 at 14:37 +0100, Jan Beulich wrote: >>>> On 23.01.2024 13:34, Oleksii wrote: >>>>> On Tue, 2024-01-23 at 12:14 +0100, Jan Beulich wrote: >>>>>> On 22.12.2023 16:13, Oleksii Kurochko wrote: >>>>>>> --- /dev/null >>>>>>> +++ b/xen/lib/find-next-bit.c >>>>>>> [...] >>>>>> >>>>>> I was going to ask that you convince git to actually present >>>>>> a >>>>>> proper >>>>>> diff, to make visible what changes. But other than the >>>>>> description >>>>>> says >>>>>> you don't really move the file, you copy it. Judging from >>>>>> further >>>>>> titles >>>>>> there's also nowhere you'd make Arm actually use this now >>>>>> generic >>>>>> code. >>>>> I wanted to do it separately, outside this patch series to >>>>> simplify >>>>> review and not have Arm specific changes in RISC-V patch >>>>> series. >>>> >>>> Then do it the other way around: Make a separate _prereq_ change >>>> truly >>>> moving the file. >>> So this one patch should be separated by 2? One which moves find- >>> next- >>> bit.c from Arm to xen/lib, and second where xen/lib/Makefile is >>> updated. >> >> No, that would break the Arm build. I suggested breaking out this >> patch from the series, and then doing what the description says: >> Actually move the file. I don't think I suggested splitting the >> patch. Even the breaking out of the series was only because you >> said "I wanted to do it separately, outside this patch series". > What I meant was that I would like to have a patch which introduces > generic version of find-next-bit in the current patch series and > provide a separate patch outside of the current patch series which > switches Arm to use generic version.
I understand that this is what you meant. Yet I don't like the duplication of code, even if it's only temporary. The more that iirc git can show proper history for moved files, while there'll be a disconnect when you first add a 2nd copy and later purge the original. If you want this change separate from the series - fine. But then, as said, please as a prereq patch. Jan
