On 18.01.2024 15:17, Julien Grall wrote: > On 11/01/2024 07:35, Jan Beulich wrote: >> It's simply not needed anymore. Note how Linux made this change many >> years ago already, in 2.6.19 (late 2006, see [1]). >> >> Signed-off-by: Jan Beulich <[email protected]> > > This patch will need to be adjusted to compile on Arm. If you > incorporate the changes from Michal (see the reply to the cover letter), > then: > > Acked-by: Julien Grall <[email protected]>
Thanks. >> [1] >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=7d12e780e003f93433d49ce78cfedf4b4c52adc5 > > NIT: I was under the impresion the tags would usually last in a commit. > So this would go before [1]. Well, I'm not sure. Personally I think footnotes better are last. If you indeed dislike this arrangement, and since I dislike "It's simply not needed anymore. Note how Linux made this change many years ago already, in 2.6.19 (late 2006, see [1]). [1] https://git.kernel.org/torvalds/c/7d12e780e003f93433d49ce78cfedf4b4c52adc5"; best I could think of would then be to go without footnote: "It's simply not needed anymore. Note how Linux made this change many years ago already, in 2.6.19 (late 2006, see https://git.kernel.org/torvalds/c/7d12e780e003f93433d49ce78cfedf4b4c52adc5";). Thoughts? Jan
