On 02.12.2023 02:27, Volodymyr Babchuk wrote: > @@ -886,6 +890,10 @@ static int deassign_device(struct domain *d, uint16_t > seg, uint8_t bus, > > pdev->fault.count = 0; > > + write_lock(&target->pci_lock); > + ret = vpci_assign_device(pdev); > + write_unlock(&target->pci_lock); > + > out: > if ( ret ) > printk(XENLOG_G_ERR "%pd: deassign (%pp) failed (%d)\n",
Considering the function we're in, I think this "assign" deserves a comment. It's necessary for hwdom only aiui, i.e. particularly not for the more typical case of putting the device in quarantine? Jan
