On 20.12.2023 03:10, Stefano Stabellini wrote: > On Sat, 2 Dec 2023, Volodymyr Babchuk wrote: >> --- a/xen/arch/x86/include/asm/msi.h >> +++ b/xen/arch/x86/include/asm/msi.h >> @@ -81,8 +81,9 @@ struct irq_desc; >> struct hw_interrupt_type; >> struct msi_desc; >> /* Helper functions */ >> -extern int pci_enable_msi(struct msi_info *msi, struct msi_desc **desc); >> -extern void pci_disable_msi(struct msi_desc *msi_desc); >> +extern int pci_enable_msi(struct pci_dev *pdev, struct msi_info *msi, >> + struct msi_desc **desc); >> +extern void pci_disable_msi(struct msi_desc *desc); > > As the parameters name should match between declaration and definition, > you should also rename msi_desc to desc in the implementation of > pci_disable_msi. Or keep the parameter called "msi_desc" for > pci_disable_msi here.
It's not clear at all why pci_disable_msi() is touched here; the description says nothing in this regard. > That change could be done on commit and everything > else looks OK: > > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
