On 2023-12-12 02:42, Stefano Stabellini wrote:
On Mon, 11 Dec 2023, Nicola Vetrini wrote:
The "return 0" after the swich statement in 'xen/arch/x86/mm.c'
is unreachable because all switch clauses end with returns.
However, some of them can be substituted with "break"s to allow
the "return 0" outside the switch to be reachable.
No functional changes.
This is correct but makes the code inconsistent. I would either remove
the return 0; at the end of arch_memory_op, or do the following:
- initialize rc to 0 at the beginning: int rc = 0;
- all switch clauses break instead of return;
- at the end: return rc;
Given the feedback on the Arm side, the first solution is likely to be
preferred.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
