On 06.12.23 12:33, Andrew Cooper wrote:
On 06/12/2023 10:59 am, Andrew Cooper wrote:On 06/12/2023 7:10 am, Juergen Gross wrote:diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h index 0a2b16d05d..0ceb06a2bb 100644 --- a/xen/include/xen/unaligned.h +++ b/xen/include/xen/unaligned.h @@ -1,12 +1,4 @@-static inline uint16_t get_unaligned_be16(const void *p) +static inline u16 get_unaligned_le16(const void *p)I've done some cleanup for you. You swapped away from using stdint types, and shuffled the order of functions, which made the diff basically illegible. https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=commitdiff;h=1d448a845ee4ad74cab76563b3a2552b10953186 is a much shorter diff.Oh, and the Origin link ought to be https://git.kernel.org/torvalds/c/803f4e1eab7a8938ba3a3c30dd4eb5e9eeef5e63 which is shorter and also lets people on the web view it.
Then we should update docs/process/sending-patches.pandoc to reflect that possibility to reference a commit (I wouldn't like that change, though). Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
