On 06.12.2023 04:10, Stefano Stabellini wrote: > On Tue, 5 Dec 2023, Federico Serafini wrote: >> @@ -572,20 +572,20 @@ int __sync_local_execstate(void); >> /* Arch-specific portion of memory_op hypercall. */ >> long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); >> long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); >> -int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void)); >> -int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void)); >> +int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) >> arg); >> +int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); > > Also for compat_subarch_memory_op I cannot find the definition
Looks like in b8a7efe8528a ("Enable compatibility mode operation for HYPERVISOR_memory_op") I blindly added the declaration, without there actually being a definition. Jan