On 01.12.2023 03:47, Stefano Stabellini wrote:
> On Wed, 29 Nov 2023, Nicola Vetrini wrote:
>> No functional change.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com>
>> ---
>> The preferred way to deviate is to use asmlinkage, but this modification is
>> only
>> the consequence of NUMA on ARM (and possibly PPC) being a work in progress.
>> As stated in the comment above the textual deviation, first_valid_mfn will
>> likely then become static and there would be no need for the comment anymore.
>> This works towards having the analysis for this rule clean (i.e. no
>> violations);
>> the interest in having a clean rule is that then it could be used to signal
>> newly introduced violations by making the analysis job fail.
>
> Please add this text as part of the commit message. It can be done on
> commit.
I assume you saw my reply on another of the patches in this series as to
asmlinkage use on variables? IOW I think this paragraph would also need
adjustment to account for that.
> With that:
>
> Acked-by: Stefano Stabellini <sstabell...@kernel.org>
>
>
>> ---
>> xen/common/page_alloc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
>> index 9b5df74fddab..794d7689b179 100644
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -258,6 +258,7 @@ static PAGE_LIST_HEAD(page_broken_list);
>> * first_valid_mfn is exported because it is use in ARM specific NUMA
>> * helpers. See comment in arch/arm/include/asm/numa.h.
>> */
>> +/* SAF-1-safe */
>> mfn_t first_valid_mfn = INVALID_MFN_INITIALIZER;
>>
>> struct bootmem_region {
>> --
>> 2.34.1
>>
