On 31/05/18 15:05, Marcello Seri wrote: > When xenstore was updated to support safe-string, some unnecessary > copies were introduced. A further patch reduced the copies at the price > of many calls to unsafe conversions between bytes and strings. In the > port we also did not notice that some C stubs were still incorrectly > using ocaml strings as mutable payload. > > This set of patches updates the C stubs that use mutable payloads passed > from ocaml, and reduces the amount of unsafe conversions where possible > without further increasing the number of copies. > > This seems also to fix some unclear instabilities that appeared after > the former patch introducing the unsafe conversion with some version of > the ocaml compiler.
This is rather vague. Can you confirm that oxenstored is now as stable as it was without the safe-string patches? Could you please mention the commit of the patch you are fixing in the related commit message? I'd like to know which of the two patches is the real fix and which is "only" some improvement of code. We are rather close to the release, so I'm hesitating to accept cleanup patches now. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
