> On 21 Nov 2023, at 09:45, Michal Orzel <michal.or...@amd.com> wrote: > > Macros load_paddr and adr_l are equivalent when used before the MMU is > enabled, resulting in obtaining physical address of a symbol. The former > requires to know the physical offset (PA - VA) and can be used both before > and after the MMU is enabled. In the spirit of using something only when > truly necessary, replace all instances of load_paddr with adr_l, except > in create_table_entry macro. Even though there is currently no use of > load_paddr after MMU is enabled, this macro used to be call in such a > context and we can't rule out that it won't happen again. > > This way, the logic behind using load_paddr/adr_l is consistent between > arm32 and arm64, making it easier for developers to determine which one > to use and when. > > Take the opportunity to fix a comment with incorrect function name. > > Signed-off-by: Michal Orzel <michal.or...@amd.com> > ---
Hi Michal, I’ve also tested on FVP Reviewed-by: Luca Fancellu <luca.fance...@arm.com> Tested-by: Luca Fancellu <luca.fance...@arm.com>