On 10.11.2023 17:30, Oleksii Kurochko wrote: > iocap.h is common for Arm, PPC and RISC-V architectures thereby > it was moved to asm-generic. > > Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> > --- > The same question as with device.h. Should it be in asm-generic?
I think it's okay(ish) here, considering that ... > --- /dev/null > +++ b/xen/include/asm-generic/iocap.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __ASM_GENERIC_IOCAP_H__ > +#define __ASM_GENERIC_IOCAP_H__ > + > +#define cache_flush_permitted(d) \ > + (!rangeset_is_empty((d)->iomem_caps)) ... the only thing referenced (iomem_caps) is a common entity. And again Arm demonstrates that an arch can get away with just this. Jan