On 13.11.23 09:58, Juergen Gross wrote:
On 10.11.23 19:05, Julien Grall wrote:Hi Juergen,On 10/11/2023 16:07, Juergen Gross wrote:Today domain_init() is called either just before calling dom0_init() in case no live update is being performed, or it is called after reading the global state from read_state_global(), as the event channel fd is needed. Split up domain_init() into a preparation part which can be called unconditionally, and in a part setting up the event channel handle.Looking at the code, domain_init() may not be called if -D is passed to Xen. With your change, part of it would not be called unconditionally.So does -D actually make sense? Did it actually work before your change? Should it be removed?Good point. I think it should be removed. I don't think it can work at all.
I even think the "-N" and "-P" should be removed, too. "-N" isn't really _that_ helpful when doing tests. Attaching gdb to the running xenstored daemon is by far superior. And if you are testing any changes in the init code you can easily patch xenstored not to daemonize. "-P" has no real purpose at all. Why would we want to show the PID, if we can just look into the pidfile? Thoughts? Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
