On 26/10/2023 11:01, Mykyta Poturai wrote:
Hi Julien,
Hi,
On 25.10.23 13:22, Julien Grall wrote:
Looking at the change, you mainly add #ifdef in the code. The goal of
gic-v3-lpi.c was to be agnostic from the different vGIC. So please
abstract it.
Would it be okay to add something like "typedef struct vgic_irq
pending_irq" to deal with the type differences or is it better to
completely move the code that mentions them into vgic files?
Looking at the code, you only seem to use vgic_irq in
vgic_vcpu_inject_lpi(). Most of the code after your patch seems to
diverge between the new vGIC and old vGIC.
So I think you want to duplicate vgic_vcpu_inject_lpi() for each vGIC.
Cheers,
--
Julien Grall
