On Wed, 2023-10-25 at 12:42 -0300, Daniel Henrique Barboza wrote: > > I believe you forgot to remove the 'nd' variable. Building with this patch > (applying > patches 1 to 4 first) fails with: > > > ../hw/riscv/microchip_pfsoc.c: In function ‘microchip_pfsoc_soc_realize’: > ../hw/riscv/microchip_pfsoc.c:205:14: error: unused variable ‘nd’ > [-Werror=unused-variable] > 205 | NICInfo *nd; > | ^~ > cc1: all warnings being treated as errors > > > Patch looks good otherwise. Thanks, > > Daniel
Thanks. Yes, I'd spotted that my build coverage was incomplete and fixed a few of those. My tree at https://git.infradead.org/users/dwmw2/qemu.git/shortlog/refs/heads/xenfv does actually build now on all platforms, and the CI tests ran in https://gitlab.com/dwmw2/qemu/-/pipelines/1049153457 with only a minor whine from checkpatch about the imported Xen headers and some long lines which were like that before I touched them. I haven't yet re-spammed the list with the 40-odd patches touching all the platforms though, as noted in https://lore.kernel.org/qemu-devel/20231025145042.627381-1-dw...@infradead.org/T/
smime.p7s
Description: S/MIME cryptographic signature
