On 19.10.2023 15:11, Simone Ballarin wrote: > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > headline states: > "A 'u' or 'U' suffix shall be applied to all integer constants > that are represented in an unsigned type". > > Add the 'U' suffix to integers literals with unsigned type. > > For the sake of uniformity, the following change is made: > - add 'U' suffixes to 'mask16' in 'stdvga.c' > > Signed-off-by: Gianluca Luparini <[email protected]> > Signed-off-by: Simone Ballarin <[email protected]> > Reviewed-by: Stefano Stabellini <[email protected]>
Acked-by: Jan Beulich <[email protected]> albeit ... > --- a/xen/arch/x86/include/asm/msr-index.h > +++ b/xen/arch/x86/include/asm/msr-index.h > @@ -22,7 +22,7 @@ > #define APIC_BASE_BSP (_AC(1, ULL) << 8) > #define APIC_BASE_EXTD (_AC(1, ULL) << 10) > #define APIC_BASE_ENABLE (_AC(1, ULL) << 11) > -#define APIC_BASE_ADDR_MASK 0x000ffffffffff000ULL > +#define APIC_BASE_ADDR_MASK _AC(0x000ffffffffff000, ULL) ... this looks like an unrelated (but benign) change. Jan
