On 11/10/2023 8:25 pm, Alejandro Vallejo wrote: > string.atoi() has been deprecated since Python 2.0, has a big scary warning > in the python2.7 docs and is absent from python3 altogether. int() does the > same thing and is compatible with both. > > See https://docs.python.org/2/library/string.html#string.atoi: > > Signed-off-by: Alejandro Vallejo <alejandro.vall...@cloud.com> > --- > tools/pygrub/src/pygrub | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub > index dcdfc04ff0..541e562327 100755 > --- a/tools/pygrub/src/pygrub > +++ b/tools/pygrub/src/pygrub > @@ -731,7 +731,7 @@ class Grub: > def get_entry_idx(cf, entry): > # first, see if the given entry is numeric > try: > - idx = string.atoi(entry) > + idx = int(entry) > return idx > except ValueError: > pass
CC Henry for 4.18. This was discovered late in the XSA-443 work and is one small extra bit of Python3 work. Thanks, ~Andrew
