Re: [XEN][PATCH v10 08/20] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

[Michal Orzel]

On 25/08/2023 10:02, Vikram Garhwal wrote:
> 
> 
> Add device_tree_find_node_by_path() to find a matching node with path for a
You renamed it in v8 so both here and in commit title: 
s/device_tree_find_node_by_path/dt_find_node_by_path_from/

> dt_device_node.
> 
> Reason behind this function:
>     Each time overlay nodes are added using .dtbo, a new fdt(memcpy of
As Julien requested: add space between fdt and (

>     device_tree_flattened) is created and updated with overlay nodes. This
>     updated fdt is further unflattened to a dt_host_new. Next, we need to find
>     the overlay nodes in dt_host_new, find the overlay node's parent in 
> dt_host
>     and add the nodes as child under their parent in the dt_host. Thus we need
>     this function to search for node in different unflattened device trees.
> 
> Also, make dt_find_node_by_path() static inline.
> 
> Signed-off-by: Vikram Garhwal <vikram.garh...@amd.com>
With the remarks addressed:
Reviewed-by: Michal Orzel <michal.or...@amd.com>

~Michal