On 28.08.2023 15:20, Simone Ballarin wrote: > --- a/xen/include/xen/unaligned.h > +++ b/xen/include/xen/unaligned.h > @@ -3,13 +3,14 @@ > * without faulting, and at least reasonably efficiently. Other > architectures > * will need to have a custom asm/unaligned.h. > */ > -#ifndef __ASM_UNALIGNED_H__ > -#error "xen/unaligned.h should not be included directly - include > asm/unaligned.h instead" > -#endif > > #ifndef __XEN_UNALIGNED_H__ > #define __XEN_UNALIGNED_H__ > > +#ifndef __ASM_UNALIGNED_H__ > +#error "xen/unaligned.h should not be included directly - include > asm/unaligned.h instead" > +#endif
In addition to what Stefano said, this repositioning also is questionable (as per comments elsewhere). Overall it looks like the entire patch wants dropping? Or wait, no, the pci_ids.h change would remain. Jan
