On 29.08.2023 00:42, Stefano Stabellini wrote: > On Mon, 28 Aug 2023, Simone Ballarin wrote: >> --- a/xen/common/efi/runtime.c >> +++ b/xen/common/efi/runtime.c >> @@ -6,6 +6,10 @@ >> #include <xen/irq.h> >> #include <xen/time.h> >> >> +#ifndef __COMMON_EFI_RUNTIME_C__ >> +#define __COMMON_EFI_RUNTIME_C__ > > Shouldn't this be at the top of the file?
Imo .c files shouldn't gain guards in the first place. Jan
