Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote:
Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access to add/remove/assign/deassign. With addition of dynamic programming feature(follow-up patches in this series),
Typo: missing space before '('.
this function can be concurrently access by pci device assign/deassign and also
I couldn't find any use of this function in the PCI code. So are you talking about not yet upstreamed patches?
Also, typo: s/access/accessed/
by dynamic node add/remove using device tree overlays. Signed-off-by: Vikram Garhwal <vikram.garh...@amd.com> Reviewed-by: Luca Fancellu <luca.fance...@arm.com> Reviewed-by: Michal Orzel <michal.or...@amd.com>
The code itself looks good to me. So I will provide my reviewed-by tag once my question about the commit message is answered.
Cheers, -- Julien Grall