Hi Julien, > On Aug 21, 2023, at 16:43, Julien Grall <jul...@xen.org> wrote: > > Hi Henry, > > On 14/08/2023 05:25, Henry Wang wrote: >> There are two types of memory system architectures available for >> Arm-based systems, namely the Virtual Memory System Architecture (VMSA) >> and the Protected Memory System Architecture (PMSA). According to >> ARM DDI 0487G.a, A VMSA provides a Memory Management Unit (MMU) that >> controls address translation, access permissions, and memory attribute >> determination and checking, for memory accesses made by the PE. And >> refer to ARM DDI 0600A.c, the PMSA supports a unified memory protection >> scheme where an Memory Protection Unit (MPU) manages instruction and >> data access. Currently, Xen only suuports VMSA. > > Typo: s/suuports/supports/
Oops, sorry about this, will fix in v6. > >> Introduce a Kconfig option CONFIG_MMU, which is currently default >> set to y and unselectable because currently only VMSA is supported. > > NIT: It would be worth to explicit mention that this will be used in > follow-up patches. So one will wonder what's the goal of introducing an > unused config. > > Or it could have been merged in the first patch splitting the MMU code so we > don't introduce a config without any use. Sure, I will think about this and fix in v6. > >> Suggested-by: Julien Grall <jgr...@amazon.com> >> Signed-off-by: Henry Wang <henry.w...@arm.com> > > Acked-by: Julien Grall <jgr...@amazon.com> Thanks! Kind regards, Henry > > Cheers, > > -- > Julien Grall
