On 12.08.2023 00:58, Stefano Stabellini wrote: > On Fri, 11 Aug 2023, Nicola Vetrini wrote: >> The missing headers declare variables 'xen_cpuidle' and 'use_invpcid' >> that are then defined inside the file. >> This is undesirable and also violates MISRA C:2012 Rule 8.4. >> Adding suitable "#include"s resolves the issue. >> >> The type of the variable 'xen_cpuidle' also changes according to >> s/s8/int8_t/. >> >> Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com> >> Fixes: 3eab82196b02 ("x86: PIT broadcast to fix local APIC timer stop issue >> for Deep C state") >> Fixes: 63dc135aeaf9 ("x86: invpcid support")
One request: Please can you get used to putting the Fixes: tags first, so one doesn't need to (try to) remember to move them in the course of committing? > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Acked-by: Jan Beulich <jbeul...@suse.com> Jan