On 12.08.23 04:32, Kevin Alarcon Negy wrote:
Apologies if I misused the "RESEND" subject line. The xen patch guide [1] seemed to suggest using it as a way to ping.Thanks for the feedback. I realize now that my misunderstanding in how the original code should work is because of my confusion between "maxmem" the config variable vs. "xl mem-max" command. I thought that both should act exactly the same way. As in, "xl mem-max" calls xc_domain_setmaxmem() and also sets the static-max variable [2]. I know that maxmem (config variable) starts out as just the static-max variable and does not result in an xc_domain_setmaxmem(maxmem) call upon bootup, but it wasn't clear to me that this was intended. My patch was intended to make both the config variable and the xl command act in the same way. Perhaps this distinction is better resolved with different naming? For instance, instead of "maxmem" for the config variable, call it "static-max" to match its internal meaning?
While you are right with "static-max" explaining the semantics for someone familiar with the internals better, I'm not sure this applies to Xen users, too. Additionally we would need to support both names after doing the switch, as we don't want to break existing config files using "maxmem". So changing the parameter name would not really help IMHO. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
