On 04.08.2023 22:45, Stefano Stabellini wrote: > On Fri, 4 Aug 2023, Nicola Vetrini wrote: >> Rename variables to avoid shadowing and thus address >> MISRA C:2012 Rule 5.3: >> "An identifier declared in an inner scope shall not hide an >> identifier declared in an outer scope". >> >> The shadowing happens between the struct declaration 'mtrr_state' in >> 'xen/arch/x86/include/asm/mtrr.h' and local variable names.
Let's try to be precise: The issue isn't with the struct declaration, but with the declaration of the global variable of that name a few lines later. Afaict - please clarify. >> The latter are renamed to 'm', which is used elsewhere in >> 'xen/arch/x86/hvm/mtrr.c' for the same purpose. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini <nicola.vetr...@bugseng.com> > > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> With - as necessary - a suitable adjustment to the description: Acked-by: Jan Beulich <jbeul...@suse.com> Jan
