On 07/08/2023 10:23, Jan Beulich wrote:
On 04.08.2023 17:27, Nicola Vetrini wrote:
Rename the local variables to avoid clashing with function 'xstate'
defined below, but declared in the corresponding header file.
Hmm, there are two functions with such a local variable, but you don't
change those. You change "xsave" instead. The new name you use you took
from older functions afaict; newer ones use "xstate" (and use of this
name is extended in pending patches), so preferably we would follow
that naming model (and eventually rename all "xsave_area" as well).
Also - does "below" really matter and hence warrant the "but"?
Jan
I made a typo in the commit message. Indeed 'xsave' here is the culprit.
I think 'xstate'
is ok for a rename, as it does not shadow anything afaict.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
