On 05/22/2018 03:37 PM, Andrew Cooper wrote: > On 22/05/18 14:48, George Dunlap wrote: >> On 05/22/2018 02:40 PM, Jan Beulich wrote: >>>>>> On 22.05.18 at 15:35, <[email protected]> wrote: >>>> --- a/xen/arch/x86/acpi/power.c >>>> +++ b/xen/arch/x86/acpi/power.c >>>> @@ -33,6 +33,8 @@ >>>> >>>> uint32_t system_reset_counter = 1; >>>> >>>> +static bool __read_mostly opt_fake_s3 = false; >>> With the typo in the title (wants to be acpi_sleep) corrected >> Oops -- I can fix this on check-in (once the development window opens). > > If this patch is necessary, or at least a useful aid to track down an S3 > bug in Xen 4.11, I vote for its inclusion. > > As far as the change itself goes, it is very simple, with a minimal > change of any unintended side effects. > > CC'ing the RM for his decision on the subject.
Using `rtcwake -s 10 -m mem`, the only difference I've seen between suspend with this patch and without is that it doesn't actually sleep for 10 seconds -- not surprising, as it was never asleep. :-) I agree that it's quite low risk; but it doesn't seem to me to be very critical either, which is why I didn't CC Juergen in the first place. But I'm fine either way. -George _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
