Fri, 28 Jul 2023 21:35:54 +0100 George Dunlap <george.dun...@cloud.com>:
> Everything looks good (including adding the missing strings), except for > the removal of the fixed array size. Call me paranoid, but if we define it > as REASON_MAX length, then there will never be any way that a value less > than REASON_MAX causes a segfault (and if we assign a value higher than > REASON_MAX, the compiler will complain); whereas if we make it variable, we > leave open the possibility that someone won't update REASON_MAX properly, > resulting in either segfaults (if REASON_MAX is too high) or missing > strings (if REASON_MAX is too low). I think the code needs to be rearranged to work with "array_size" instead. Olaf
pgpkqdwQ_lR5u.pgp
Description: Digitale Signatur von OpenPGP
