Re: [PATCH v2 10/18] tools/xenstore: add hashtable_replace() function

[Juergen Gross]

On 18.07.23 22:50, Julien Grall wrote:

Hi Juergen,

On 10/07/2023 07:59, Juergen Gross wrote:

For an effective way to replace a hashtable entry add a new function
hashtable_replace().

While at it let hashtable_add() fail if an entry with the specified
key does already exist.

This seems to be a left-over from the previous version.

Yes, will remove it.

This is in preparation to replace TDB with a more simple data storage.

Signed-off-by: Juergen Gross <jgr...@suse.com>
---
  tools/xenstore/hashtable.c | 20 ++++++++++++++++++++
  tools/xenstore/hashtable.h | 16 ++++++++++++++++
  2 files changed, 36 insertions(+)

diff --git a/tools/xenstore/hashtable.c b/tools/xenstore/hashtable.c
index 29c247f918..0c26a09567 100644
--- a/tools/xenstore/hashtable.c
+++ b/tools/xenstore/hashtable.c

      return NULL;
  }
+

@@ -160,6 +160,7 @@ static struct entry *hashtable_search_entry(const struct hashtable *h,

I think this belong to the previous patch.

Indeed it does,


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature