On Wed, 12 Jul 2023, Jan Beulich wrote: > On 12.07.2023 12:32, Simone Ballarin wrote: > > From: Gianluca Luparini <gianluca.lupar...@bugseng.com> > > > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > > headline states: > > "A 'u' or 'U' suffix shall be applied to all integer constants > > that are represented in an unsigned type". > > > > Add the 'U' suffix to integers literals with unsigned type. > > > > For the sake of uniformity, the following changes are made: > > - add the 'U' suffix to macros near > > 'CPU_BASED_ACTIVATE_SECONDARY_CONTROLS' and > > 'SECONDARY_EXEC_NOTIFY_VM_EXITING' macros in 'vmcs.h' > > - add the 'U' suffix to macros near 'INTR_INFO_VALID_MASK' > > macro in 'vmx.h' > > > > Signed-off-by: Gianluca Luparini <gianluca.lupar...@bugseng.com> > > Signed-off-by: Simone Ballarin <simone.balla...@bugseng.com> > > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > > --- > > Changes in v3: > > - change 'Signed-off-by' ordering > > - change commit message > > - remove unnecessary changes in 'vvmx.c' > > - add 'uint32_t' casts in 'vvmx.c' > > - add missing 'U' in 'vmcs.h' macros > > - change macro to '(1u << 31)' in 'vmx.h' > > - remove unnecessary changes to 'vmx.h' > > With this many changes I don't think you can retain an R-b, unless > the person it came from really explicitly agreed with at least all > not purely cosmetic changes (which I don't think was the case here).
I re-reviewed it: Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > Irrespective: > Reviewed-by: Jan Beulich <jbeul...@suse.com> > > Jan >
