Hi,
On 05/07/2023 10:53, Penny Zheng wrote:
Since if not and when anyone wants to update map_pages_to_xen(),
destroy_xen_mappings() and modify_xen_mappings() in the future, it is
possible for them to leave changes in only one file.
The helpers are just wrappers. I doubt they will change in the future.
So I think it would be OK to duplicate.
The alternative would to have a common prototype for xen_pt_update()
and xen_mpumap_update() and avoid any #ifdery. That said, this is not
my preference at least if they are not static inline.
Correct me if I'm wrong, you are suggesting something like this:
A more-generic wrapper like xen_mm_update, and we introduce static
inline implementation in mmu/mm.h with xen_pt_update(), and static
inline implementation in mpu/mm.h with xen_mpumap_update().
Yes as an alternative proposal. But my preference here is to duplicate
the helpers in mm-mmu.c and mm-mpu.c.
Cheers,
--
Julien Grall
