On 22.06.2023 17:30, Anthony PERARD wrote:
> Defining ARCH and SRCARCH later in xen/Makefile allows to switch to
> immediate evaluation variable type.
>
> ARCH and SRCARCH depends on value defined in Config.mk and aren't used
> TARGET_SUBARCH or TARGET_ARCH, and not before it's needed in a
> sub-make or a rule.
Something looks to be missing in this sentence. I first thought it
was merely a "by", but I don't see how TARGET_{,SUB}ARCH matter
here.
> This will help reduce the number of times the shell rune is been
> run.
>
> With GNU make 4.4, the number of execution of the command present in
> these $(shell ) increased greatly. This is probably because as of make
> 4.4, exported variable are also added to the environment of $(shell )
> construct.
>
> Also, `make -d` shows a lot of these:
> Makefile:39: not recursively expanding SRCARCH to export to shell function
> Makefile:38: not recursively expanding ARCH to export to shell function
>
> Reported-by: Jason Andryuk <[email protected]>
> Signed-off-by: Anthony PERARD <[email protected]>
> Tested-by: Jason Andryuk <[email protected]>
With some suitable adjustment
Reviewed-by: Jan Beulich <[email protected]>
Jan
