Hi,
On 19/06/23 12:29, Julien Grall wrote:
Hi,
On 19/06/2023 11:25, Jan Beulich wrote:
On 19.06.2023 12:01, Julien Grall wrote:
On 19/06/2023 10:56, Nicola Vetrini wrote:
In the files `xen/arch/arm/include/asm/arm(32|64)/flushtlb.h' there
are a
few occurrences of nested '//' character sequences inside C-style
comment
blocks, which violate Rule 3.1. The patch aims to resolve those by
removing
the nested comments.
As I wrote in
https://lore.kernel.org/xen-devel/f3fc1848-68ca-37a1-add2-e100b4773...@xen.org/,
I am against replacing '//' with nothing. I have proposed to use ';'
because this is also a valid way to comment in assembly.
Are you sure about this? For gas most targets use ; as a statement
separator,
not as a comment character. Afaics arm-* and aarch64-* are no
exception there.
GAS will not accept it. But the Arm compiler will [1]. This is good
enough for me because I want to have a separator between the instruction
and the comment.
Cheers,
[1]
https://developer.arm.com/documentation/dui0473/m/structure-of-assembly-language-modules/syntax-of-source-lines-in-assembly-language
If no one has any objection about this I'll add the ';' comment delimiter.
Regards,
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
