On Thu, May 17, 2018 at 12:16:58PM +0100, Ian Jackson wrote: > Logically, the final branch of the if should be qualified with a check > for the emptiness of FreeBSDDist. This is awkward in the current > structure, since we really want to do the distpath lookup only if > needed. (This is not very important right now, but we are about to > add another case which will do a more-likely-to-bomb-out and > more-likely-to-block-on-the-db lookup.) So refactor into `return' > style. This lets us introduce local variables in each branch. > > Now gate the final branch appropriately. The overall result is that > if no useful FreeBSD build is found, we simply do not set the > freebsd_* runvars, rather than setting them to wrong values (eg, > `freebsd_distpath=/i386'. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com>
Reviewed-by: Roger Pau Monné <roger....@citrix.com> Thanks. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
